Headings not in sequence (paginator)
https://artsandsciences.osu.edu/admin/people Paginator on this page has an invisible h4 on it to help SR users navigate to it. This h4 is out of sequence. Comments:
- I think this may be a mistake. I'm seeing
Let me know if I'm overlooking something (Brian Canini - Dec 2, 2022)
- It jumps from the previous heading
h2
"Breadcrumb" to theh4
"Pagination". Pagination could be made anh3
but I don't know if that would cause problems on other pages.
On this page they are using several invisible headings to label global parts of the page for accessibility. I'm not sure if this is old fashioned style accessibility, or what. Doing it that way is fragile because you never know what headings are going to be in the changing parts of the page.
If this is impossible, or silly convoluted to fix, we can record it in the exceptions list. It's not making anything truly inaccessible. (Jeff Borisch - Dec 5, 2022)
- Ah, I see it now (Brian Canini - Dec 6, 2022)
- Using the following jQuery I can change this tag to an
if (jQuery('#pagination-heading').length) {
jQuery('#pagination-heading').replaceWith('<h3 id="pagination-heading" class="visually-hidden">Pagination</h3>');
}
``` (Brian Canini - Dec 6, 2022)
- Change can be reviewed at https://acc-upd-ascmainsite-d8.pantheonsite.io/admin/people (Brian Canini - Dec 6, 2022)
- This fix should resolve any other pages with a similar hierarchy setup (Brian Canini - Dec 6, 2022)
- js fix and drupal's js aggregation didn't play nicely together and ended up breaking the media popup which also had a pagination div in it (Brian Canini - Dec 8, 2022)
- Let's undo this and note that we can't be fixed without module hacking. (Jeff Borisch - Dec 8, 2022)