Skip to content
Snippets Groups Projects
Unverified Commit 9c5d99d0 authored by weaver299's avatar weaver299 Committed by GitHub
Browse files

Merge pull request #326 from ASCWebServices/canini-2

updating .theme, js, and styles for new people filters
parents d07b1f32 61f6502d
No related branches found
No related tags found
No related merge requests found
 . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
 . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
 . . . . . . . . . . .:8 ;t;;t;;;;:..:;%SX888@X%t;.. . . . 
 . . .. . . . . . .%t%;%@%%%%%%%%%%X@8888XS%t;...:;ttt%X. .
 . . . . . . . . .X:8%X%%%XS%%%%%%%XS%%%%%@%%%%X%%%@%S88 . 
 . . . . . . . . X@ @%%%X8X%%%88%%%8X%%%%%%%%%XXt@8@88@. .
 . . . . . . . .t@tS;%%8XSX%@XSX%@XSS%8@@88X@888X8SS S;S. 
 . . . . . . .@%XS%%%%%S8@X%@8%XXSSXX%S@SSSX888.;@ 888@ . . 
 . . . . . :.8:S%%%XS8X@@X%S@SSSS8SXSXXX%X88X:;@8@:S  88S. .
 . . . .8%S8%%%%%%8@SSSXXXSXSXSXSXSSS8S888 :@%:%XX:%8%:X: 
 . . .:8 %%%%@%%8@S%%XXSXSSSS8S@X%XSXX88 ;@X;SX88X8;%X88t. 
 . . 88S%S%%%%8XSSXSX@@S@%XS8@SS%@S%888 88@S:8. .;.@%X:@8;. 
 . .  88.8888888@XX 888888%X%@XX 88SS8@@;S@8.%;8@S%%:8  .
 . .  S%:8 @SSSS8 @@8@8 8 88888888@%S:8:S8 @..%S SXX8888;. .
 . . %:8S8888@88SXS S S::X@.8.8 X%S%8X:X88..% @@.S.%% .;. . 
 . .XX8@8;;%%t;;;;:@X@888888@888888.88S;8:8  ... . . .
 . . 8.;;@8@8:%%%%%t.8@%ttX@8@@@S8%8 X8S;X:@; :... . . . . .
 . tS:8@;88.;:8888X8S:.tX88888X88  S8tStS88 :.. . . . . . . 
 .:X;;:t%;tt%888S@8XS888@8.:tt@;88.tXXX8:::... . . . . . . .
 .:X8St:8SXS XS8@X 8.8%888%X8@@X88tXS8t; . . . . . . . . . 
 . :8888.88888888X@@X @ X X%S%;88;8t .. . . . . . . . .
 ... ..: . .@@888%St @ @ 8SS 8:; . . . . . . . . . . .
 . . . ..::. ..:;;::::. ... . . . . . . . . . . . .
 .. . . . . .. . . . . .. . . . . . . . . . . . . . 
...@@ -599,11 +599,35 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $ ...@@ -599,11 +599,35 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $
* people filters * people filters
*/ */
if($form['#id'] == 'views-exposed-form-people-directory-page-1') { if($form['#id'] == 'views-exposed-form-people-directory-page-1') {
/*
* add new HTML content to filters (headers and spacer)
* and setting weights for where they should appear in the form hierarchy
*/
$form['filter_heading'] = array(
'#markup' => '<h2 class="filter-heading">Filter</h2>',
'#weight' => -10,
);
$form['filter_search_heading'] = array(
'#markup' => '<div class="filter-linebreak"></div>',
'#weight' => 4,
);
$form['spacer'] = array(
'#markup' => '<div class="filter-spacer"></div>',
'#weight' => 1.5,
);
/*
* setting up weights for form elements
*/
$form['field_appointment_target_id']['#weight'] = 1;
$form['field_research_interests_target_id']['#weight'] = 2;
$form['field_other_target_id']['#weight'] = 3;
$form['combine']['#weight'] = 5;
$form['keys']['#attributes']['placeholder'] = t('Search Keywords');
/* /*
* checking if taxonomy has vocabulary - if not, don't display field * checking if taxonomy has vocabulary - if not, don't display field
*/ */
if(count($form['field_appointment_target_id']['#options']) == 0) { if(count($form['field_appointment_target_id']['#options']) == 0) {
$form['field_appointment_target_id']['#access'] = FALSE; $form['field_appointment_target_id_collapsible']['#access'] = FALSE;
} }
else { else {
$tid = array_shift(array_keys($form['field_appointment_target_id']['#options'])); $tid = array_shift(array_keys($form['field_appointment_target_id']['#options']));
...@@ -613,13 +637,13 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $ ...@@ -613,13 +637,13 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $
if(!empty($vid)) { if(!empty($vid)) {
$vocab = Vocabulary::load($vid); $vocab = Vocabulary::load($vid);
$vocab_label = $vocab->get('name'); $vocab_label = $vocab->get('name');
$form['#info']['filter-field_appointment_target_id']['label'] = $vocab_label; $form['field_appointment_target_id_collapsible']['#title'] = $vocab_label;
} }
} }
} }
if(count($form['field_research_interests_target_id']['#options']) == 0) { if(count($form['field_research_interests_target_id']['#options']) == 0) {
$form['field_research_interests_target_id']['#access'] = FALSE; $form['field_research_interests_target_id_collapsible']['#access'] = FALSE;
} }
else { else {
$tid = array_shift(array_keys($form['field_research_interests_target_id']['#options'])); $tid = array_shift(array_keys($form['field_research_interests_target_id']['#options']));
...@@ -629,14 +653,14 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $ ...@@ -629,14 +653,14 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $
if(!empty($vid)) { if(!empty($vid)) {
$vocab = Vocabulary::load($vid); $vocab = Vocabulary::load($vid);
$vocab_label = $vocab->get('name'); $vocab_label = $vocab->get('name');
$form['#info']['filter-field_research_interests_target_id']['label'] = $vocab_label; $form['field_research_interests_target_id_collapsible']['#title'] = $vocab_label;
} }
} }
} }
if(count($form['field_other_target_id']['#options']) == 0) { if(count($form['field_other_target_id']['#options']) == 0) {
$form['field_other_target_id']['#access'] = FALSE; $form['field_other_target_id_collapsible']['#access'] = FALSE;
} }
else { else {
$tid = array_shift(array_keys($form['field_other_target_id']['#options'])); $tid = array_shift(array_keys($form['field_other_target_id']['#options']));
...@@ -646,7 +670,7 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $ ...@@ -646,7 +670,7 @@ function asc_bootstrap_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $
if(!empty($vid)) { if(!empty($vid)) {
$vocab = Vocabulary::load($vid); $vocab = Vocabulary::load($vid);
$vocab_label = $vocab->get('name'); $vocab_label = $vocab->get('name');
$form['#info']['filter-field_other_target_id']['label'] = $vocab_label; $form['field_other_target_id_collapsible']['#title'] = $vocab_label;
} }
} }
} }
......
...@@ -223,7 +223,15 @@ ...@@ -223,7 +223,15 @@
// -------------------------------------------------- // --------------------------------------------------
//## Events. //## Events.
.path-events {
.page-header {
margin: 44px 0 0;
border-bottom: none;
}
}
.view-events { .view-events {
.view-filters { .view-filters {
background: #D8D8D8; background: #D8D8D8;
padding: 10px 20px; padding: 10px 20px;
...@@ -234,6 +242,14 @@ ...@@ -234,6 +242,14 @@
width: 100%; width: 100%;
} }
.filter-linebreak {
padding: 8px;
@media (max-width: 1200px) {
display: none;
}
}
.filter-spacer { .filter-spacer {
display: none; display: none;
...@@ -283,8 +299,19 @@ ...@@ -283,8 +299,19 @@
.form-actions { .form-actions {
.button {
text-transform: uppercase;
border-radius: 0;
}
.form-submit { .form-submit {
float: right; float: right;
@media (max-width: 768px) {
width: 100%;
margin: 10px 0;
float: none;
}
} }
.btn-primary { .btn-primary {
...@@ -297,9 +324,9 @@ ...@@ -297,9 +324,9 @@
} }
} }
.button { @media (max-width: 768px) {
text-transform: uppercase; display: flex;
border-radius: 0; flex-direction: column-reverse;
} }
} }
...@@ -309,7 +336,15 @@ ...@@ -309,7 +336,15 @@
// -------------------------------------------------- // --------------------------------------------------
//## Gallery filters. //## Gallery filters.
.path-gallery {
.page-header {
margin: 44px 0 0;
border-bottom: none;
}
}
.view-gallery-directory { .view-gallery-directory {
.control-label { .control-label {
display: none; display: none;
} }
...@@ -324,6 +359,14 @@ ...@@ -324,6 +359,14 @@
width: 100%; width: 100%;
} }
.filter-linebreak {
padding: 8px;
@media (max-width: 1200px) {
display: none;
}
}
.filter-spacer { .filter-spacer {
width: 100%; width: 100%;
margin-top: 15px; margin-top: 15px;
...@@ -370,8 +413,19 @@ ...@@ -370,8 +413,19 @@
.form-actions { .form-actions {
.button {
text-transform: uppercase;
border-radius: 0;
}
.form-submit { .form-submit {
float: right; float: right;
@media (max-width: 768px) {
width: 100%;
margin: 10px 0;
float: none;
}
} }
.btn-primary { .btn-primary {
...@@ -384,9 +438,9 @@ ...@@ -384,9 +438,9 @@
} }
} }
.button { @media (max-width: 768px) {
text-transform: uppercase; display: flex;
border-radius: 0; flex-direction: column-reverse;
} }
} }
...@@ -396,7 +450,15 @@ ...@@ -396,7 +450,15 @@
// -------------------------------------------------- // --------------------------------------------------
//## News story. //## News story.
.path-news {
.page-header {
margin: 44px 0 0;
border-bottom: none;
}
}
.view-news { .view-news {
.view-filters { .view-filters {
background: #D8D8D8; background: #D8D8D8;
padding: 10px; padding: 10px;
...@@ -407,6 +469,14 @@ ...@@ -407,6 +469,14 @@
width: 100%; width: 100%;
} }
.filter-linebreak {
padding: 8px;
@media (max-width: 1200px) {
display: none;
}
}
.filter-spacer { .filter-spacer {
display: none; display: none;
...@@ -456,8 +526,19 @@ ...@@ -456,8 +526,19 @@
.form-actions { .form-actions {
.button {
text-transform: uppercase;
border-radius: 0;
}
.form-submit { .form-submit {
float: right; float: right;
@media (max-width: 768px) {
width: 100%;
margin: 10px 0;
float: none;
}
} }
.btn-primary { .btn-primary {
...@@ -470,16 +551,219 @@ ...@@ -470,16 +551,219 @@
} }
} }
@media (max-width: 768px) {
display: flex;
flex-direction: column-reverse;
}
}
}
// --------------------------------------------------
//## People Directory.
.path-people {
.page-header {
margin: 44px 0 0;
border-bottom: none;
}
}
.view-people-directory {
.view-filters {
background: #D8D8D8;
padding: 10px;
}
.filter-heading {
color: #225D62;
width: 100%;
}
.filter-linebreak {
@media (max-width: 1200px) {
display: none;
}
}
.filter-spacer {
display: none;
@media (max-width: 1200px) {
display: block;
}
}
.select-wrapper {
margin-right: 10px;
select {
min-width: 250px;
@media (max-width: 1200px) {
margin-top: 10px;
min-width: 273px;
}
@media (max-width: 768px) {
margin-top: 0;
min-width: 0;
}
}
&:after {
color: #555555;
font-size: 12px;
}
@media (max-width: 768px) {
width: 100%;
}
}
.form-type-textfield {
margin-right: 10px;
input {
min-width: 250px;
}
@media (max-width: 768px) {
width: 100%;
}
}
}
#views-exposed-form-people-directory-page-1 {
.form-item {
margin-right: 20px;
.panel-heading {
padding: 0 15px;
.panel-title {
.fa {
float: right;
margin-top: 5px;
}
}
}
@media (max-width: 768px) {
width: 100%;
}
}
.form-checkbox {
-webkit-appearance: none;
-moz-appearance: none;
-ie-appearance: none;
background-color: #fafafa;
border: 1px solid #cacece;
box-shadow: 0 1px 2px rgba(0,0,0,0.05);
padding: 9px;
border-radius: 3px;
display: inline-block;
position: relative;
top: 4px;
margin-right: 10px;
&:active, &:checked:active {
box-shadow: 0 1px 2px rgba(0,0,0,0.05), inset 0px 1px 3px rgba(0,0,0,0.1);
}
&:checked {
background-color: #442369;
border: 1px solid #adb8c0;
box-shadow: 0 1px 2px rgba(0,0,0,0.05), inset 0px -15px 10px -12px rgba(0,0,0,0.05), inset 15px 10px -12px rgba(255,255,255,0.1);
color: #99a1a7;
}
&:checked:after {
content: '\2713';
font-size: 14px;
position: absolute;
top: 0px;
left: 3px;
color: $white;
}
}
.form-item-combine {
@media (max-width: 768px) {
width: 100%;
}
}
.form-actions {
.button { .button {
text-transform: uppercase; text-transform: uppercase;
border-radius: 0; border-radius: 0;
} }
.form-submit {
float: right;
@media (max-width: 768px) {
width: 100%;
margin: 10px 0;
float: none;
}
}
.btn-primary {
background-color: #26686d;
border-color: #225d62;
&:hover {
background-color: #1b494c;
border-color: #1e5357;
}
}
@media (max-width: 768px) {
display: flex;
flex-direction: column-reverse;
}
}
}
.block-views-exposed-filter-blockpeople-directory-page-1 {
padding: 20px 0px;
.form-wrapper {
margin-top: 20px;
legend {
text-transform: uppercase;
color: #4A4A4A;
font-weight: bold;
font-size: 18px;
border-bottom: none;
margin-bottom: 5px;
}
} }
} }
// -------------------------------------------------- // --------------------------------------------------
//## Research Directory. //## Research Directory.
.path-research-project-directory{
.page-header {
margin: 44px 0 0;
border-bottom: none;
}
}
.view-research-project-directory { .view-research-project-directory {
.view-filters { .view-filters {
...@@ -492,6 +776,14 @@ ...@@ -492,6 +776,14 @@
width: 100%; width: 100%;
} }
.filter-linebreak {
padding: 8px;
@media (max-width: 1200px) {
display: none;
}
}
.form-type-textfield { .form-type-textfield {
margin-right: 10px; margin-right: 10px;
...@@ -514,8 +806,19 @@ ...@@ -514,8 +806,19 @@
.form-actions { .form-actions {
.button {
text-transform: uppercase;
border-radius: 0;
}
.form-submit { .form-submit {
float: right; float: right;
@media (max-width: 768px) {
width: 100%;
margin: 10px 0;
float: none;
}
} }
.btn-primary { .btn-primary {
...@@ -528,9 +831,9 @@ ...@@ -528,9 +831,9 @@
} }
} }
.button { @media (max-width: 768px) {
text-transform: uppercase; display: flex;
border-radius: 0; flex-direction: column-reverse;
} }
} }
...@@ -540,7 +843,15 @@ ...@@ -540,7 +843,15 @@
// -------------------------------------------------- // --------------------------------------------------
//## Research Directory Mobile. //## Research Directory Mobile.
.path-research-project-directory-mobile{
.page-header {
margin: 44px 0 0;
border-bottom: none;
}
}
.view-research-project-directory-mobile { .view-research-project-directory-mobile {
.view-filters { .view-filters {
background: #D8D8D8; background: #D8D8D8;
padding: 10px; padding: 10px;
...@@ -551,6 +862,14 @@ ...@@ -551,6 +862,14 @@
width: 100%; width: 100%;
} }
.filter-linebreak {
padding: 8px;
@media (max-width: 1200px) {
display: none;
}
}
.form-item { .form-item {
background: $white; background: $white;
padding: 5px 10px; padding: 5px 10px;
...@@ -595,8 +914,19 @@ ...@@ -595,8 +914,19 @@
.form-actions { .form-actions {
.button {
text-transform: uppercase;
border-radius: 0;
}
.form-submit { .form-submit {
float: right; float: right;
@media (max-width: 768px) {
width: 100%;
margin: 10px 0;
float: none;
}
} }
.btn-primary { .btn-primary {
...@@ -609,9 +939,9 @@ ...@@ -609,9 +939,9 @@
} }
} }
.button { @media (max-width: 768px) {
text-transform: uppercase; display: flex;
border-radius: 0; flex-direction: column-reverse;
} }
} }
...@@ -642,7 +972,15 @@ ...@@ -642,7 +972,15 @@
// -------------------------------------------------- // --------------------------------------------------
//## Research Gallery filters. //## Research Gallery filters.
.path-research-project-gallery{
.page-header {
margin: 44px 0 0;
border-bottom: none;
}
}
.view-research-project-gallery { .view-research-project-gallery {
.control-label { .control-label {
display: none; display: none;
} }
...@@ -657,6 +995,14 @@ ...@@ -657,6 +995,14 @@
width: 100%; width: 100%;
} }
.filter-linebreak {
padding: 8px;
@media (max-width: 1200px) {
display: none;
}
}
.filter-spacer { .filter-spacer {
width: 100%; width: 100%;
margin-top: 15px; margin-top: 15px;
...@@ -703,8 +1049,19 @@ ...@@ -703,8 +1049,19 @@
.form-actions { .form-actions {
.button {
text-transform: uppercase;
border-radius: 0;
}
.form-submit { .form-submit {
float: right; float: right;
@media (max-width: 768px) {
width: 100%;
margin: 10px 0;
float: none;
}
} }
.btn-primary { .btn-primary {
...@@ -717,10 +1074,13 @@ ...@@ -717,10 +1074,13 @@
} }
} }
.button { @media (max-width: 768px) {
text-transform: uppercase; display: flex;
border-radius: 0; flex-direction: column-reverse;
} }
} }
} }
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
//## People grid. //## People grid.
.view-people-directory { .view-people-directory {
margin-bottom: 40px;
h3 { h3 {
text-transform: uppercase; text-transform: uppercase;
...@@ -71,180 +70,38 @@ ...@@ -71,180 +70,38 @@
} }
} }
} }
.square-opic {
max-width: 220px;
max-height: 220px;
overflow: hidden;
position: relative;
&:after {
content: "";
display: block;
padding-bottom: 100%;
}
@media (max-width: 768px) {
max-width: 100%;
max-height: 630px;
}
}
.square-opic-content {
position: absolute;
width: 100%;
height: 100%;
}
} }
.view-display-id-page_1 {
margin-bottom: 40px;
// --------------------------------------------------
//## Siderbar and Filters form.
.block-views-exposed-filter-blockpeople-directory-page-1 {
padding: 20px 0px;
} }
#views-exposed-form-people-directory-page-1 { .square-opic {
.form-item { max-width: 220px;
width: 100%; max-height: 220px;
} overflow: hidden;
position: relative;
.form-checkbox {
-webkit-appearance: none;
-moz-appearance: none;
-ie-appearance: none;
background-color: #fafafa;
border: 1px solid #cacece;
box-shadow: 0 1px 2px rgba(0,0,0,0.05);
padding: 9px;
border-radius: 3px;
display: inline-block;
position: relative;
top: 4px;
&:active, &:checked:active {
box-shadow: 0 1px 2px rgba(0,0,0,0.05), inset 0px 1px 3px rgba(0,0,0,0.1);
}
&:checked {
background-color: #442369;
border: 1px solid #adb8c0;
box-shadow: 0 1px 2px rgba(0,0,0,0.05), inset 0px -15px 10px -12px rgba(0,0,0,0.05), inset 15px 10px -12px rgba(255,255,255,0.1);
color: #99a1a7;
}
&:checked:after { &:after {
content: '\2713'; content: "";
font-size: 14px; display: block;
position: absolute; padding-bottom: 100%;
top: 0px;
left: 3px;
color: $white;
}
} }
.form-wrapper { @media (max-width: 768px) {
margin-top: 20px; max-width: 100%;
max-height: 630px;
legend {
text-transform: uppercase;
color: #4A4A4A;
font-weight: bold;
font-size: 18px;
border-bottom: none;
margin-bottom: 5px;
}
}
label {
width: 90%;
margin-left: 28px;
input {
margin-left: -28px;
margin-right: 8px;
}
} }
} }
.square-opic-content {
position: absolute;
// -------------------------------------------------- width: 100%;
height: 100%;
//## Mobile View.
#views-exposed-form-people-directory-page-2 {
background: #D8D8D8;
padding: 10px;
details {
background: #ffffff;
padding: 5px 10px;
border-radius: 8px;
margin: 10px 0;
}
.ppl-filter-heading {
color: #225D62;
margin: 5px 0;
text-transform: capitalize;
}
.ppl-taxon-heading {
margin-top: 20px;
}
.form-checkbox {
-webkit-appearance: none;
-moz-appearance: none;
-ie-appearance: none;
background-color: #fafafa;
border: 1px solid #cacece;
box-shadow: 0 1px 2px rgba(0,0,0,0.05), inset 0px -15px 10px -12px rgba(0,0,0,0.05);
padding: 9px;
border-radius: 3px;
display: inline-block;
position: relative;
top: 4px;
margin-right: 5px;
&:active, &:checked:active {
box-shadow: 0 1px 2px rgba(0,0,0,0.05), inset 0px 1px 3px rgba(0,0,0,0.1);
}
&:checked {
background-color: #442369;
border: 1px solid #adb8c0;
box-shadow: 0 1px 2px rgba(0,0,0,0.05), inset 0px -15px 10px -12px rgba(0,0,0,0.05), inset 15px 10px -12px rgba(255,255,255,0.1);
color: #99a1a7;
}
&:checked:after {
content: '\2713';
font-size: 14px;
position: absolute;
top: 0px;
left: 3px;
color: $white;
}
}
#edit-submit-people-directory {
text-transform: uppercase;
}
#edit-reset {
text-transform: uppercase;
}
} }
// -------------------------------------------------- // --------------------------------------------------
//## Bio. //## Bio.
...@@ -280,11 +137,6 @@ ...@@ -280,11 +137,6 @@
h1 { h1 {
margin-bottom: 0; margin-bottom: 0;
} }
.bio-pronoun {
font-size: 14px;
font-style: italic;
}
} }
} }
......
This diff is collapsed.
...@@ -85,6 +85,11 @@ jQuery(document).ready(function(){ ...@@ -85,6 +85,11 @@ jQuery(document).ready(function(){
}); });
} }
//add arrow to people filter taxonomy
if(jQuery("#views-exposed-form-people-directory-page-1").length) {
jQuery(".panel-title").append("<i class='fa fa-angle-down' aria-hidden='true'></i>");
}
//accordions change fontawesome character //accordions change fontawesome character
jQuery(".panel-title").click(function(){ jQuery(".panel-title").click(function(){
//jQuery(this).find("svg").toggleClass('fa-angle-up', addOrRemove); //jQuery(this).find("svg").toggleClass('fa-angle-up', addOrRemove);
...@@ -136,9 +141,9 @@ jQuery(document).ready(function(){ ...@@ -136,9 +141,9 @@ jQuery(document).ready(function(){
}*/ }*/
//redirect if mobile for people directory main page //redirect if mobile for people directory main page
if(((window.location.pathname == '/people')||(window.location.pathname == '/directory')) && (jQuery(window).width() <= 740)) { // if(((window.location.pathname == '/people')||(window.location.pathname == '/directory')) && (jQuery(window).width() <= 740)) {
document.location = "people-mobile"; // document.location = "people-mobile";
} // }
//redirect if mobile for research directory main page //redirect if mobile for research directory main page
if((window.location.pathname == '/research-project-directory') && (jQuery(window).width() <= 740)) { if((window.location.pathname == '/research-project-directory') && (jQuery(window).width() <= 740)) {
document.location = "research-project-directory-mobile"; document.location = "research-project-directory-mobile";
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment