define constants with define() instead of variable assignment

web/modules/custom/asc_courses/src/AscCoursesApi.php

@@ -59,14 +59,14 @@ public function __construct($config = null, $db = null, $environment = '') {
       $this->base_url = "https://apig.eip.osu.edu/";
       $this->consumer_key = $config->get('asc_courses.prod_consumer_key');
       $this->consumer_secret = $config->get('asc_courses.prod_consumer_secret');
-      $this->soip_constant_name = "PANTHEON_SOIP_EIP_PROD";
+      define($this->soip_constant_name, "PANTHEON_SOIP_EIP_PROD");
     }
     else {
       $this->environment = $environment;
       $this->base_url = "https://apig-qa.eip.osu.edu/";
       $this->consumer_key = $config->get('asc_courses.qa_consumer_key');
       $this->consumer_secret = $config->get('asc_courses.qa_consumer_secret');
-      $this->soip_constant_name = "PANTHEON_SOIP_EIP";
+      define($this->soip_constant_name, "PANTHEON_SOIP_EIP");
     }
 
     // (Legacy) Pantheon "Secure Integration" support - establish "resolve host"